Torsten Grote

Review code for thread-safety issues

1

So far, we use `MutableStateFlow`s that get updated from Kotlin coroutines on `Dispatchers.IO` which maybe use several I/O threads. We should check if there's any issues with that like if...

The `FileManager` zips all files together while we start sharing. This action can be cancelled by the user or other errors along the way. After successful sharing, but also in...

Allow Selection of Notebooks to use with Account

2

Currently, you need to specify a root folder when creating an account. This is not optimal from a UX point of view. For example, when users create a new notebook...

Sync changes immediately

6

When changing a note, the change made should be uploaded to the server immediately so it is available to other users of the same notebook (potentially using another client) as...

Conflict Handling

6

When a note was changed on the server and on the client, this should be detected as a conflict and means should be provided to the user to resolve this...

Script hanging with 0.4.0 release

3

This is not a qualified bug report as I didn't have much time with debugging, but I tried all sorts of ways of using version 0.4.0 of this library and...

``` java.lang.NullPointerException: null cannot be cast to non-null type org.jetbrains.uast.UMethod at com.thirdegg.lintrules.android.CheckedExceptionsDetector$createUastHandler$1.visitCallExpression(CheckedExceptionsDetector.kt:68) at com.android.tools.lint.client.api.UElementVisitor$DispatchPsiVisitor.visitCallExpression(UElementVisitor.kt:523) at com.android.tools.lint.client.api.UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1071) at org.jetbrains.uast.kotlin.KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:164) at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:29) at org.jetbrains.uast.UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21) at org.jetbrains.uast.kotlin.KotlinUBlockExpression.accept(KotlinUBlockExpression.kt:11) at org.jetbrains.uast.ULambdaExpression$DefaultImpls.accept(ULambdaExpression.kt:41) at org.jetbrains.uast.kotlin.KotlinULambdaExpression.accept(KotlinULambdaExpression.kt:11) at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:29)...

``` ClassCastException:CheckedExceptionsDetector$createUastHandler$1.visitCallExpression(CheckedExceptionsDetector.kt:93) ←UElementVisitor$DispatchPsiVisitor.visitCallExpression(UElementVisitor.kt:570) ←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1103) ←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:186) ←ImplementationUtilsKt.acceptList(implementationUtils.kt:23) ←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21) ←KotlinUBlockExpression.accept(KotlinUBlockExpression.kt:24) ←ULambdaExpression$DefaultImpls.accept(ULambdaExpression.kt:33) ``` Message: class org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression cannot be cast to class org.jetbrains.uast.UCallExpression (org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression and org.jetbrains.uast.UCallExpression are in unnamed module of loader java.net.URLClassLoader @374b2be5)

IndexOutOfBoundsException in DepartureAdapter

1

``` ruby Exception java.lang.IndexOutOfBoundsException: Asked to get item at -1 but size is 0 at androidx.recyclerview.widget.SortedList.get (SortedList.java:706) at de.grobox.transportr.departures.DepartureAdapter.getItem (DepartureAdapter.java:96) at de.grobox.transportr.departures.DeparturesActivity.loadMoreDepartures (DeparturesActivity.java:238) at de.grobox.transportr.departures.DeparturesActivity.lambda$onCreate$0 (DeparturesActivity.java:127) at de.grobox.transportr.departures.DeparturesActivity.$r8$lambda$3f5aVX6MH5h4XzeWB06Qw6Y12cc (DeparturesActivity.java) at...

Navitia: Add Brazil providers

4

Currently working in São Paulo, Rio de Janeiro, Belo Horizonte and Porto Alegre. Both providers have been used in Transportr already. Time to upstream.