Transportr icon indicating copy to clipboard operation
Transportr copied to clipboard

Added collapse long trip warning messages

Open anjandev opened this issue 7 years ago • 5 comments

Uses library: https://github.com/Carbs0126/ExpandableTextView

output

This gif was made with commit https://github.com/grote/Transportr/commit/09f451a75f1c529a4eec0d730a40f7a6aa86f249 (test code).

Test code was then removed with commit: https://github.com/grote/Transportr/commit/39f4f0fb7c63342fffd934b42c240600cfa97d52.

Fixes issue #422.

anjandev avatar Sep 15 '18 21:09 anjandev

@TheLastProject fixed unintentional tabs to spaces

anjandev avatar Sep 15 '18 22:09 anjandev

@anjandev thanks a lot for the PR!

Are these "Expand" links always shown, or only when the text exceeds a certain lenght?

grote avatar Oct 13 '18 16:10 grote

Torsten Grote [email protected] writes:

@anjandev thanks a lot for the PR! No problem. Thank you for reviewing.

Are these "Expand" links always shown, or only when the text exceeds a certain lenght? Expand is only shown when text exceeds a certain length. See: https://user-images.githubusercontent.com/8602360/46909957-af371980-cf2a-11e8-926d-e9cf8cf58eee.png

Why do we need to add this? I don't really understand the chinese on the libraries' page. I dont understand chinese either but this was the only library I could make work. Furthermore, this library allows us to have the simpliest code.

I deleted the attr file and the code compiles and runs fine. I just made a new commit deleting the attr file.

Thanks for the feedback.

anjandev avatar Oct 13 '18 20:10 anjandev

@grote Is there any reason this was never merged and is there anything I can do to get it into a state that can be merged?

anjandev avatar Jul 17 '19 05:07 anjandev

Where does the Expand text come from? Can it be localized into other languages by Transportr's translators?

What happens if some notices are expanded and some or not and you rotate the screen? Does this library maintain the expanded state across configuration changes?

grote avatar Sep 26 '19 14:09 grote