BlitzMail icon indicating copy to clipboard operation
BlitzMail copied to clipboard

Set subject when sending files

Open guest4711 opened this issue 8 years ago • 8 comments
trafficstars

When you have shared a lot of files using thr wonderful Blitzmail it's hard to gind them in your mailfolder because alle subject header show the same (non-linformation: 1 file shared with Blitzmail.

So I would like to have an option in settings to allow Blitzmail to create a subject including the filename like [Blitzmail] name_of_transmittted_file

This would help a lot. I prefer an option for that because not everybody would like to have this info in metadata or server logs...

guest4711 avatar May 26 '17 08:05 guest4711

I'd be happy to implement that. I have a few questions before I go ahead:

  • Should it be able to display more than one file name, perhaps as many as can fit under 70 chars, eg:
    • File1.jpg, File2.jpg, and 3 more files shared with Blitzmail
    • File1.jpg and File2.jpg shared with Blitzmail?
    • File1.jpg shared with Blitzmail
  • Is making it optional really necessary?

ducalex avatar May 13 '21 18:05 ducalex

Thanks for volunteering to pick this up!

The first option might still get problematic in other languages, but maybe it could cut whatever is too long?

I don't think there needs to be a setting for this.

grote avatar May 14 '21 23:05 grote

The first option might still get problematic in other languages, but maybe it could cut whatever is too long?

Yes I was suggesting that BlitzMail would show as many filenames as can fit without exceeding a certain subject length.

But maybe to avoid having messing with translations we could simply do:

  • File1.png | 1 File(s) shared with BlitzMail
  • File1.png, ... | 8 File(s) shared with BlitzMail

Basically just prepend the first filename to the current subject. What do you think?

ducalex avatar May 16 '21 22:05 ducalex

Sounds good. Maybe the suffix could even be shortened somehow. .. | 8 files blitzMailed.

Bonus point for using a plural string that uses the s only when needed.

grote avatar May 17 '21 12:05 grote

Or File1.png, File2.jpg and 8 other files biltzMailed.

grote avatar May 17 '21 12:05 grote

Sorry for the long delay! I'm back with some free time and the code is done we just need to decide on the format.

I'm fine with both your suggestions but they require a locale update for all languages, is that something we wish? (I don't know how much work it is).

ducalex avatar Aug 25 '21 18:08 ducalex

I personally don't mind that translations need to be adapted.

grote avatar Aug 28 '21 18:08 grote

After experimenting a bit with different formats I settled on something different. I've made a pull request with it but I really don't mind changing to any other format if you prefer, I just want this feature to be merged :).

Let me know if I need to update the translations (and how), it's only two words so I should be able to do all languages.

ducalex avatar Aug 31 '21 19:08 ducalex