groovy-eclipse icon indicating copy to clipboard operation
groovy-eclipse copied to clipboard

No source bundles in update site

Open felixdo opened this issue 8 years ago • 5 comments

There don't seem to be no source bundles for groovy eclipse on the update site.

felixdo avatar May 18 '17 11:05 felixdo

Ok, so the intention is that org.codehaus.groovy.eclipse.sdk carries the sources, but that feature isn't being built. It doesn't even have a pom.

felixdo avatar May 26 '17 11:05 felixdo

Since 2.9.1 there have been some changes to the features that are pushed out to the update site. This happened before my time, so I am uncertain of the reasoning behind these changes. I will have a look at how JDT packages up "Eclipse JDT Developer Resources" and "Eclipse PDE Plug-in Developer Resources" and see if I can refactor the SDK feature into an "Eclipse Groovy Plug-in Developer Resources" that includes the source bundles. Last time I checked with the CI builds, they are creating the source bundles; they simply aren't included in any deployed features.

eric-milles avatar May 26 '17 14:05 eric-milles

You can assign to me I will look at it tonight.

On May 26, 2017 16:54, "Eric Milles" [email protected] wrote:

Since 2.9.1 there have been some changes to the features that are pushed out to the update site. This happened before my time, so I am uncertain of the reasoning behind these changes. I will have a look at how JDT packages up "Eclipse JDT Developer Resources" and "Eclipse PDE Plug-in Developer Resources" and see if I can refactor the SDK feature into an "Eclipse Groovy Plug-in Developer Resources" that includes the source bundles. Last time I checked with the CI builds, they are creating the source bundles; they simply aren't included in any deployed features.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/groovy/groovy-eclipse/issues/296#issuecomment-304304094, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK9z0yO91hQ5glchUcgnSyNmzzkEn4Cks5r9ueSgaJpZM4NfGHV .

felixdo avatar May 26 '17 14:05 felixdo

Eric do you know if there was ever a site for a version that did include source features since the tycho build? I fiddled a bit with the tycho source-feature generation, but I can't get it to include the generated features into the update site :(

felixdo avatar May 27 '17 19:05 felixdo

Hmhm it's kind of what I feared: The catch is, using the (deprecated) eclipse-update-site allows to publish the jdt feature patch but not source features. We should use eclipse-repository, but that means complications to the feature-patch procedure...

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=497840 https://bugs.eclipse.org/bugs/show_bug.cgi?id=389698 (comment 2 mentions that you cannot publish source features with eclipse-update-site)

felixdo avatar May 28 '17 07:05 felixdo