groovy-eclipse icon indicating copy to clipboard operation
groovy-eclipse copied to clipboard

formatter: remove multiple duplicated, add additional spaces in some cases

Open mojo2012 opened this issue 5 years ago • 1 comments

So I created another PR for my formatter changes.

#941

mojo2012 avatar Feb 20 '20 08:02 mojo2012

A couple notes to start with:

  1. When you edit a source in org.codehaus.groovyXX, you will likely need to make changes to the same source in the other groovy version bundles.
  2. Have you run these changes on a larger codebase to see if they cause any problems for less common source constructs? The tests are often very simple and I'm not sure of the overall coverage of the formatter tests specifically.
  3. Are any of these formatter settings configurable? The original issue mentions the Java formatter settings. If possible, it would be best to support the same preferences so you can get a similar result for Java and Groovy files.
  4. Is it possible to divide these changes into some smaller groups so we can review and merge in smaller increments?

eric-milles avatar Feb 20 '20 15:02 eric-milles