hpe-design-system icon indicating copy to clipboard operation
hpe-design-system copied to clipboard

Published 20 hours ago • verified publisher icon grommet

add email input to feedback

Open britt6612 opened this issue 9 months ago • 4 comments

Deploy Preview

What does this PR do?

add email option for our feedback on DS site

Where should the reviewer start?

layout.js

What testing has been done on this PR?

locally In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • [ ] Small, medium, and large screen sizes
  • [ ] Cross-browsers (FireFox, Chrome, and Safari)
  • [ ] Light & dark modes
  • [ ] All hyperlinks route properly

Accessibility Checks

  • [ ] Keyboard interactions
  • [ ] Screen reader experience
  • [ ] Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • [ ] Console is free of warnings and errors
  • [ ] Passes E2E commit checks
  • [ ] Visual snapshots are reasonable

How should this be manually tested?

locally

Any background context you want to provide?

be nice to have an option for users to give their contact (if they want) so we can follow up on any feedback that is left for us

What are the relevant issues?

just came up in Slack

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

no

Is this change backwards compatible or is it a breaking change?

backwards compatible

britt6612 avatar Feb 21 '25 19:02 britt6612

⚠️ No Changeset found

Latest commit: 41cd5b3ef24d896c2a19487440c6f70a2ca192c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 21 '25 19:02 changeset-bot[bot]

Deploy Preview for rad-shortbread-897892 failed.

Name Link
Latest commit 41cd5b3ef24d896c2a19487440c6f70a2ca192c1
Latest deploy log https://app.netlify.com/sites/rad-shortbread-897892/deploys/67e5fa541315ba0008ed43a9

netlify[bot] avatar Feb 21 '25 19:02 netlify[bot]

Deploy Preview for unrivaled-bublanina-3a9bae failed.

Name Link
Latest commit 41cd5b3ef24d896c2a19487440c6f70a2ca192c1
Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/67e5fa54591243000835cd67

netlify[bot] avatar Feb 21 '25 19:02 netlify[bot]

Turning to draft until I hear back from Doris for api but feel free to still look at wording

britt6612 avatar Feb 21 '25 21:02 britt6612

closing in favor of https://github.com/grommet/hpe-design-system/pull/5251

britt6612 avatar Aug 07 '25 05:08 britt6612