grommet-starter-existing-app
grommet-starter-existing-app copied to clipboard
grommet
Revert @material-ui/core dependency to ^3.3.0
Resolve an issue with the classnames dependency. See the Grommet issue #3148 'Module not found "classnames"?' for more info https://github.com/grommet/grommet/issues/3148
@jastuccio I like it so far, I checked it locally & found it to compile fine. Of course the maintainers would have final say at this. Until then we can improve one more thing. We can sign your commit as per contribution guidelines at https://github.com/grommet/grommet/blob/master/CONTRIBUTING.md#sign-your-work I learnt about it only this week and it helps open source projects licensing.
For your existing commit you could do git commit --amend --no-edit -s and git will rewrite your commit and add a signature with your email. This may be unnecessary, but it would be awesome if we can do it anyway and it would make work more complete.
I like the commit message a lot because it is precise and meaningful. Great work there 🎉
@jastuccio BTW I didn't know until now that github has draft pull request as a feature, I was using WIP plugin (a popular plugin from years back). #TIL
Thank you for the compliment. This is a small update. I wonder if this tutorial will need to be updated to use material UI 4 someday?
I added my signature/email to the pull request. I also accidentally merged the branch I created into master. I am unsure if that matters. I still need to learn about undoing things in git.
@jastuccio PR looks good. Let's change the draft status and it would be ready to be merged by our awesome maintainers.
About MUI 4, think about what we can do and maybe in a few weeks we can revisit your idea. We can use this thread to discuss it further. I'll look at it too.