grommet-site icon indicating copy to clipboard operation
grommet-site copied to clipboard

Published 20 hours ago • verified publisher icon grommet

Grommet patterns improvements

Open vjpr opened this issue 6 years ago • 2 comments

  • Add link to Grommet Patterns site.
  • Clicking Grommet icon in the top-left of the Patterns site should return to v2.grommet.io.
  • The pattern pages should contain the actual components, not images. People want to play around with them and the codebox is slow to load1.
  • The dashboard pattern Demo link was really slow to load (15s) with not loading indicator.

vjpr avatar Jan 29 '19 21:01 vjpr

hi @vjpr ! welcome to our community and thank you for filing your first issue on grommet!

-the link to grommet-patterns site isn't official, @MikeWalrath we need to discuss it further weather to add a link to it on our site and make it more bullet proof if we do.

-any other suggestions that are not slow IYO rather than codesandbox?

-I'm not sure why the dashboard wasn't working from the grommet-patterns site, it is live and working here https://l7nyp5697.codesandbox.io/

-as I mentioned grommet-patterns is not our official site, so please use the codesandbox direct dashboard https://codesandbox.io/u/grommetux/sandboxes if you encounter any problems with it.

we appreciate your feedback, very helpful!

ShimiSun avatar Jan 30 '19 04:01 ShimiSun

If i may add, here's https://github.com/alexlee-dev/grommet-patterns the code for pattens in case issues need to get opened on that project

-any other suggestions that are not slow IYO rather than codesandbox?

(I am big fan of gatsby) An alternative could be to have patterns as gatsby websites hosted on netlify! it could be something like https://grommet-pattern-x.netlify.com and all of them could be on the same repo.

OTOH this solution is lacking some very nice features of codesandbox:

  • being able to play and modify the pattern easily
  • it could be pretty tightly coupled to gatsby's logic of routing so examples showing react-router or so could be difficult to port (never tried)

A plus of this solution is that patterns could live in the grommet repo (or here) and community could contribute/report errors when things change on subsequent grommet release. it could even be a base for unit-testing them as well.

oorestisime avatar Jan 30 '19 07:01 oorestisime