grommet-site icon indicating copy to clipboard operation
grommet-site copied to clipboard

Use official components in the official site

Open iMerica opened this issue 5 years ago • 1 comments

I've read through the source code of this repo and I get the sense that it's not very grommet-y.

For example, many areas refer to <Header/>, but this header is not the official component called <Header/>, it's a custom one. Also There is a ton of references to <Section/>. Section seems like such an important component for official site layout to make sense, but yet its missing from Grommet core. The same goes for Tile. Also, how come Header, Footer, Main aren't used?

All of these things create a false expectation of Grommet.

iMerica avatar Feb 26 '20 17:02 iMerica

I agree with @oorestisimeon

Header Footer Main and similar components were introduced just recently so probably nobody took time to update the site but i agree it needs to dogfood as much as possible.

https://grommet.slack.com/archives/C04LMHN59/p1582739958037000

ShimiSun avatar Feb 26 '20 19:02 ShimiSun