grommet-icons icon indicating copy to clipboard operation
grommet-icons copied to clipboard

[Bug] Icon "WifiLow" is not visible

Open MXXXXXS opened this issue 3 years ago • 3 comments

Bug reproduced here: https://codesandbox.io/s/elastic-cherry-3d4zm?file=/src/App.tsx

Seems to be caused by this line

https://github.com/grommet/grommet-icons/blob/2ee60efcb385ae6565fa5e0897e61cf3eda70c98/src/js/StyledIcon.js#L42

demo

MXXXXXS avatar Mar 15 '21 04:03 MXXXXXS

Which grommet-icons version are you using? I think this issue was fixed on the latest version.

ShimiSun avatar Mar 15 '21 04:03 ShimiSun

Which grommet-icons version are you using? I think this issue was fixed on the latest version.

version 4.5.0

MXXXXXS avatar Mar 15 '21 04:03 MXXXXXS

You are correct, I've verified that WifiMedium, Wifi, WifiNone are working as expected, but not WifiLow.

ShimiSun avatar Mar 15 '21 19:03 ShimiSun

we tried to make a pr to change the icon but it show this error

Screenshot_7 the ony problem to show the icon properly is to delete fillrule:"evenodd" Screenshot_6

albertoncp avatar Feb 05 '23 14:02 albertoncp

Thanks for making a PR to fix this issue! Don't worry about the error from codeclimate, it is just complaining about similar blocks of code which is okay in this case.

jcfilben avatar Feb 07 '23 19:02 jcfilben

Fixed in https://github.com/grommet/grommet-icons/pull/317

jcfilben avatar Jun 16 '23 15:06 jcfilben