grommet-icons icon indicating copy to clipboard operation
grommet-icons copied to clipboard

Published 20 hours ago • verified publisher icon grommet

Added the Kubernetes icon

Open bowdeng opened this issue 4 years ago • 4 comments

Noticed the script to create icons added a class='cls-1' which the linter didn't like. Removed it with apparently no ill effects.

bowdeng avatar Jul 06 '20 17:07 bowdeng

Hi buddy, I see the PR deployment had failed, did you follow the instructions on CONTRIBUTING.md?

ShimiSun avatar Jul 07 '20 02:07 ShimiSun

Hi Shimi

Yup. Looking at the logs it seems to be when it was preparing the repo which suggests it had problems communicating with my forked version. I tried anonymously cloning and it was fine so I’m a bit confused. All the tests locally ran and after some cleaning up the pre-commit hooks all passed too. I’ll have a play again today but if you’ve any ideas what might have occurred happy to try again.

Glyn

bowdeng avatar Jul 07 '20 04:07 bowdeng

Thanks buddy! @L0ZZI can you please approve the svg before I'll attempt to fix this branch?

ShimiSun avatar Jul 07 '20 15:07 ShimiSun

The SVG looks good!

vavalos5 avatar Apr 29 '21 17:04 vavalos5

This has been open a while now and the main is very far ahead

bowdeng avatar Sep 11 '23 13:09 bowdeng