Steven Kirk

Results 205 comments of Steven Kirk
trafficstars

> I wouldn't want to use CommandParameter however since it would prevent using this by the user. I mean what happens if the user tries something like this: ? `CommandParameter`...

> I've looked at current bindings implementation and probably opening user access to BindingExpressionBase (and probably UntypedBindingExpressionBase) will allow creating custom binding and shouldn't(?) break anything. Just a bit of...

We already have a way of allowing access to private APIs ;) It's a little bit hidden because we don't want loads of people using it and then blaming us...

Fixed by #162

Is this PR still relevant? I see that in the linked issue @robloo says: > @maxkatz6 I haven't seen this issue since https://github.com/AvaloniaUI/Avalonia/pull/8918. Is there any reason to keep this...

Does anyone have a minimal repro for this? Not quite sure what's happening here. It looks like a binding isn't being marshaled to the UI thread, but I'm not sure...

Ok I've taken a look and the problem isn't that the binding isn't being marshaled to the UI thread. The problem seems to be that `InpcPropertyAccessorPlugin` uses [weak events](https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Base/Data/Core/Plugins/InpcPropertyAccessorPlugin.cs#L188) and...

> In WPF it's also not required to write x:Key, as it can be assumed from TargetType: Yep, we need to add that feature to the XAML compiler.

I also am not 100% sure why this change was made. @Takoooooo or @kekekeks could you explain in more detail why it's not a good idea to create instances of...