Steven Kirk

Results 205 comments of Steven Kirk

It would also be nice to have these builtins: https://msdn.microsoft.com/en-us/library/ee792002%28v=vs.110%29.aspx?f=255&MSPPError=-2147217396

Any change of this getting fixed? Or if you could point me in the right direction I could take a look.

Thanks for taking a look Kent. I've tried delving into it myself but I'll need more time to familiarize myself with how it all works. The minimal repro you posted...

I had linked the wrong issue in a PR, this shouldn't have been closed.

This happens because the DevTools hosts its own theme in the MainWindow[1] https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Diagnostics/Diagnostics/Views/MainWindow.xaml#L13 And when StaticResourceExtension.ProvideValue is called, the XAML parent stack looks like this: ``` [0] {Avalonia.Controls.ScrollViewer} object {Avalonia.Controls.ScrollViewer}...

Testing against WPF, this scenario also fails there: ```xml ``` Where `But.xaml` has `ButtonStyle1` which has a `StaticResource` which references the `Red` resource in `Red.xaml`: ``` System.Windows.Markup.XamlParseException: ''Provide value on...

I don't think we want to use a script to merge our themes, we have a XAML compiler which could do this automatically, but that will require a bit of...

A few more benchmarks, this time `ControlsBenchmark`: ``` master | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |---------------...

I've not fully reviewed this PR, but so far I only have two comments: - As mentioned in the issue, the term "theme" is overloaded. Maybe something like "theme variant"...