actools icon indicating copy to clipboard operation
actools copied to clipboard
verified publisher icon gro-ove

Online - fix crash in server selection (Wine)

Open MrXANA91 opened this issue 1 year ago • 19 comments

Description

This pull request aims to give (at least) a temporary solution to issue #106 and its dupplicate(s).

While the root cause could not be entirely determined, it appears that deactivating the images rendering in servers description prevent the crash from happening. This PR adds a checkbox setting in the Online/Display category to hide images in server description (deactivated by default).

Hide images in server description checkbox screenshot

Detailed changes

  • Added a boolean setting HideImagesInServersDescription (deactivated by default)
  • Added a checkbox control in the Online/Display category to control the boolean setting
  • Added a filter function to the server description string when receiving server information, that filters out the img tags if the boolean setting is enabled
  • Added a string ressource to AppString for the HideImagesInServersDescription checkbox text :
    • Settings_Online_HideImagesInServerDescription --> "Hide images render in servers description"

Checklist

  • [x] Code compile
  • [x] Problem is solved
  • [ ] String ressource for all languages (translation)
  • [ ] Solve inconsistency when changing setting after some servers info have already been loaded

Github commands

fix #106 fix #109

MrXANA91 avatar Jul 16 '24 08:07 MrXANA91

This PR is only for reference as the repo is a bit outdated. Some changes are also weirdly huge (see the AppStrings files).

Main maintainer will be contacted.

MrXANA91 avatar Jul 16 '24 08:07 MrXANA91

Marking this as Ready, even if some changes are still required. Advises are welcomed.

MrXANA91 avatar Jul 16 '24 08:07 MrXANA91

I couldn't find a compiled version, so I compiled it myself. Since we don't know when this will be merged into the main branch, this should work for now. It requires a newer version but works fine as is. [DO NOT UPDATE THE AC, AS IT WILL REMOVE THE PATCH.]

Download

I'm providing the compiled version for x86. If the URL doesn't work, please try another mirror: GitHub: Content Manager.zip Mega.nz Mediafire file.io

If any of the file/links seem suspicious, you can compile it yourself.

How to apply this patch?

Everything is explained in this video: Watch Tutorial

Instead of downloading the original Content Manager from the site, download the patched version provided in this Pull Request/Comment.

robke96 avatar Aug 04 '24 17:08 robke96

@gro-ove please 🙏

sihawido avatar Mar 10 '25 16:03 sihawido

I just rebased this PR, I'll test it later today.

Edit: yup, i forgot about it. Testing it this weekend.

MrXANA91 avatar Mar 13 '25 12:03 MrXANA91

Recompiled and tested to the latest commit of the master branch (c204f8dfd608b1238a335c1edbbbb6cb0e23f5a1) :

Like @robke96 said, if you don't trust random people on the Internet giving you .exe files online (you shouldn't), you can recompile the project using this branch.

MrXANA91 avatar Apr 12 '25 22:04 MrXANA91