Stephen Sugden

Results 83 comments of Stephen Sugden

@ksjogo sure, my changes are in this branch: https://github.com/grncdr/react/tree/eslint-plugin-react-hooks-static-hooks-config You can use it by installing `@grncdr/eslint-plugin-react-hooks` and updating the config as described in https://github.com/facebook/react/issues/16873#issuecomment-536346885

I’m curious about that use case: what is the useAxios hook doing that couldn’t be accomplished with a normal import?

I think this discussion would benefit from some clarification of what is possible and what is feasible. To that end, I'm writing below the limits on what I would personally...

> I think it is possible to pass a parameter to "eslint-plugin-react-hooks" in `.eslintrc`, with the names of the hooks that are static? Yep, that’s what this issue proposes and...

@douglasjunior could you provide an example of what you mean? I didn’t understand what you wanted to demonstrate with the PR you linked.

@alirezamirian do you know if ESlint makes it possible/easy to get the AST information for imported modules? I was under the impression it only worked on a single file at...

> Aside: is there any reason why you'd monkeypatch RailsEventStore::AfterCommitAsyncDispatcher instead of passing your own project-specific dispatcher to RailsEventStore::Client initializer? Actually no 😅. I am passing a project-specific scheduler to...

Test failure appears to be unrelated: ``` W, [2022-03-26T18:44:48.868951 #22] WARN -- : memcached:11211 failed (count: 0) Timeout::Error: execution expired -- rails test rails/activesupport/test/cache/behaviors/cache_store_behavior.rb:416 ```

@ghiculescu sorry for taking so long to get around to this. I've rebased and added an entry to the changelog.

> I feel like most of these methods and attributes would be better implemented directly on the `ActiveSupport::Deprecation` class... Definitely agree > but we would need to go through a...