Gregory Lee comments

Results 318 comments of


                                            Gregory Lee

multithreading issues

Thanks, the `fn.cpustring` does work once initialize has been called. Sorry about missing that in the docs. Regarding performance, I do not expect all functions to benefit from multithreading, but...

adding a test suite and continuous integration

It does not hurt to keep the issue open as a reminder to add this in the future. You could remove the "review comment" label and add a label like...

bayer_demosaic operator incorrectly expects RGB/RGBA input image

Thank @jaydcarlson. I agree that it is confusing that a 3rd dimension (which I think must be size 1) is required. I can open an issue to update the operator...

ENH: ndimage: extend ndimage filter axes support to correlate and convolve

Thanks everybody for reviewing, this MR and gh-20811 have now both been rebased and use `xp` in the new test cases.

ENH: ndimage: extend ndimage filter axes support to correlate and convolve

> thanks for taking the time to get these tests working for the alternative backends @grlee77. If you run into any problems here or in the other PR feel free...

Improve performance of `peak_local_max` and feature detectors that rely on it

I will fix the test failures. Should be fixed now by reverting the change to `ensure_spacing` as it works with general coordinates that may not have originated as pixels so...

add axes support in ndimage filters module

rebased and added one new commit that should fix the test failures when using older SciPy versions

add axes support in ndimage filters module

/test mini

add axes support in ndimage filters module

@asi1024, do you know if the couple of failures above were just timeout on the CI? should we retry?

Distributed Fragments with Conditions

> I'm am now leaning toward that this is potentially a bug. One issue is that unlike for single-fragment applications, distributed applications do NOT have any `DownstreamMessageAffordableCondition` on output ports...