Gregory Lee

Results 318 comments of Gregory Lee

@alexdesiqueira, @eldad-a. I would like to release 0.19 fairly soon. Is this something you still want to try and get into that release or should we bump back the milestone...

Thanks, @tlambert03. It looks like a nice solution! For reference of other reviewers, [TYPE_CHECKING]( https://docs.python.org/3/library/typing.html#typing.TYPE_CHECKING) is defined when tools like `mypy` are running, but not at runtime, so this should...

pinging @stefanv as this is relevant to [SPEC 1](https://scientific-python.org/specs/spec-0001/) and could warrant mentioning there

In your case is the `image` array C-contiguous? You can check by doing: ```Python print(image.flags) ``` which should give something like ``` C_CONTIGUOUS : True F_CONTIGUOUS : False OWNDATA :...

Also, if the above is not the problem, can you provide the raw image array rather than the screenshot linked above so that we can try to reproduce the issue?...

I don't think we currently have any test cases for `inpaint` that have NaN values in the image, so that could also be a potential source of the issue. I...

Did you try checking the contiguity as mentioned above to ensure your image has C-contiguous memory layout? I could not reproduce the failure with the script below (although I did...

Thanks for contributing this @AlexaKrnacova! These do seem like popular methods that would be nice to have. I did not get a chance to take a close look yet, but...

I have not reviewed the code in detail, but can you make it clearer in the docstring and the text at the top of the example what distance is being...

It looks like const fused type memory views were recently merged (cython/cython#3118), so we should be able to revisit this now