Dmitry Arkhipov

Results 252 comments of Dmitry Arkhipov

So, making sure that every .cpp file includes this specific file is simpler than making sure one .cpp file includes src.hpp?

Actually it's worse than that. The file with the macro would have to be included _before any file from Boost.JSON_. This setup screams "potential ODR violation".

It doesn't matter if the devs _need_ to include a certain magic header. What matters is if they include a header from Boost.JSON before the magic header (which they can,...

> first of all: if twice include in single file - here header guard may help That's actually an additional problem for your setup. ```c++ // json/value.hpp #infdef BOOST_JSON_VALUE_HPP #define...

I am closing this. Contrary to OP's opinion, making this "macro makes the library header-only" is a significant refactoring task, and it will still be a source of constant "why...

Looking at our embedded sources of ryu I discovered that it only allows 17 decimal digits in mantissa (and even asserts on it). After some research I've confirmed that 17...

We technically already support this for _parsing_. Just use `basic_parser` with a custom handler. The caveat is that this is way more complicated than it should have been. We could...

Here's an example of what I meant: https://godbolt.org/z/KE7YK7h97

The number will still be parsed. But our parser doesn't call `std::strod` (or any other standard number parsing utility for that matter). We use custom number parsing functions, so maybe...

An option to disable number parsing outright? I have a PR for that (#901). IIRC, my benchmarking shows that for number-heavy inputs the speed of parsing increases by 80% (but...