grist-core icon indicating copy to clipboard operation
grist-core copied to clipboard

Webhook trigger update by column

Open CamilleLegeron opened this issue 1 year ago • 2 comments

Context

#763

Done

Screencast from 06-02-2024 11:44:39.webm Screencast from 06-02-2024 11:46:48.webm

I used a string for columnIds because it seems to be difficult to show only the list corresponding to the selected tableId to the user. If we change the list shown to the user we change it for all instance of webhooks, that it's not acceptable.

CamilleLegeron avatar Jan 25 '24 16:01 CamilleLegeron

The last error seams to have no link to my feature ..

CamilleLegeron avatar Feb 06 '24 15:02 CamilleLegeron

Thanks @CamilleLegeron for the contribution! I'm afraid I'm not working at GristLabs any more though, so I've requested review from others.

alexmojaki avatar Feb 07 '24 16:02 alexmojaki

Hi, I just put a new notification for you paulfitz in case you haven't seen this PR. Sorry if your are too busy, in that case I can ask other dev in gristlabs to review this PR.

CamilleLegeron avatar Mar 20 '24 10:03 CamilleLegeron

The test failure looks relevant:

(1) DocApi should work directly with a docworker Webhooks /webhooks endpoint should call to a webhook only when columns updated are in watchedColIds if not empty
AssertionError: expected false to be true
    ...
    at assertSuccessCalled (test/server/lib/DocApi.ts:4448:18)
    at Context.<anonymous> (test/server/lib/DocApi.ts:4490:15)

paulfitz avatar Mar 26 '24 19:03 paulfitz

The test failure looks relevant:

(1) DocApi should work directly with a docworker Webhooks /webhooks endpoint should call to a webhook only when columns updated are in watchedColIds if not empty
AssertionError: expected false to be true
    ...
    at assertSuccessCalled (test/server/lib/DocApi.ts:4448:18)
    at Context.<anonymous> (test/server/lib/DocApi.ts:4490:15)

Well ... I don't understand why this error happen, reinitializing the migration it works well

CamilleLegeron avatar Mar 27 '24 10:03 CamilleLegeron

@paulfitz, send you this notification in case you haven't seen I worked on this PR :)

CamilleLegeron avatar Apr 04 '24 08:04 CamilleLegeron