tidyms icon indicating copy to clipboard operation
tidyms copied to clipboard

Example wrong?

Open sorenwacker opened this issue 3 years ago • 2 comments

Hi, the library looks very promising although I have some starting issues. I was following the quickstart guide.

https://tidyms.readthedocs.io/en/latest/quickstart.html

import os
# creates a list of path to each data file to analyze
path = "data"
file_list = [os.path.join(path, x) for x in os.listdir(path)]
roi, feature_data = ms.detect_features(data_path, separation="uplc",
                                        instrument="qtof")

It seems like data_path actually has to be file_list. The errors could be a bit more informative. When passed in the above example it returns File is a directory for some reason. At least with my custom input. Maybe you could add a type check and return a more informative message. It would also be nice if pathlib objects would be supported.


from pathlib import Path
Path('/mydatadir/')


sorenwacker avatar May 19 '21 23:05 sorenwacker