griptape
griptape copied to clipboard
SQLAlchemy 2.0 not supported
Describe the bug Getting this error from poetry when attempting to add griptape to an existing sqlalchemy project
Using version ^0.14.7 for griptape
Using version ^0.16.3 for griptape-tools
Updating dependencies
Resolving dependencies... (0.3s)
Because griptape (0.14.7) depends on sqlalchemy (>=1.0,<2.0)
and no versions of griptape match >0.14.7,<0.15.0, griptape (>=0.14.7,<0.15.0) requires sqlalchemy (>=1.0,<2.0).
So, because good-ads depends on both sqlalchemy (^2.0.19) and griptape (^0.14.7), version solving failed.
To Reproduce
poetry add griptape griptape-tools
Expected behavior Install griptape
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: macOS
- Version 13.3.1
Additional context Add any other context about the problem here.
@iloveitaly, hey Mike! 😄
We are currently relying on some sqlalchemy 1.x
-specific functionality but we should definitely upgrade to 2.x
. Thanks for bringing this up!
@vasinov good to finally work with you on something :)
Yeah, totally makes sense. The trick is it prevents any sqlalchemy 2.0 projects from using griptape. If the 1.x functionality is optional if you aren't using any persistence-related functionality, that would be even better.
This is an obstacle to adoption for me.
Curious what 1.x functionality is being relied upon / if you would accept a pull request for this work.
@mattgiles, 1.x
is used in a handful of classes but the most significant blocker is in SqlDriver.get_table_schema()
. Not a terribly hard migration but we just haven't gotten to it yet. If you'd like to submit a PR it would be most appreciated. Thanks!
@vasinov looks totally doable. I started down the path, but believe this issue is blocked by snowflake-sqlalchemry here. Hopefully they can figure that out.
@mattgiles, ah, yes. that's another blocker that I forgot about.
https://github.com/snowflakedb/snowflake-sqlalchemy/pull/469 was finally merged, hopefully they make a release soon.