laravel-mysql-spatial icon indicating copy to clipboard operation
laravel-mysql-spatial copied to clipboard

Laravel 10

Open limenet opened this issue 1 year ago • 4 comments

Core changes:

  • Adds support for Laravel 10
  • Use PHPUnit 10
  • Use namespaces in tests

Packages changes thanks to https://github.com/spatie/package-skeleton-laravel:

  • Use GitHub Actions instead of Travis CI
  • Use PHPStan to ensure code quality
  • Use Laravel Pint to fix code style

Some changes may not be required, let me know if/what you'd like me to revert. And thanks for all your work!

limenet avatar Mar 12 '23 10:03 limenet

@limenet try a look at https://github.com/asanikovich/laravel-spatial

asanikovich avatar Jun 02 '23 02:06 asanikovich

@limenet Can you please publish this pull request as a new package?

This package is not being maintained since 2020.

OzanKurt avatar Jul 06 '23 19:07 OzanKurt

@OzanKurt Normally I'm hesitant to take over a package but as you mentioned, this package appears to be abandoned, so there's a new repository now over at https://github.com/limenet/laravel-mysql-spatial.

Before I tag a release, could you please give it a try?

  1. See https://github.com/limenet/laravel-mysql-spatial#migration-from-grimzylaravel-mysql-spatial for a (very) short migration guide
  2. Please install the package using composer require limenet/laravel-mysql-spatial:dev-master for now

If you find any issues, please let me know by opening an issue (or even a pull request!). Thank you!

Compared to this PR, I made a few more changes that shouldn't affect functionality (except for the namespace change mentioned in the README):

  • Changed namespace from Grimzy\ to Limenet\
  • PHPStan level increased from 6 to 8
  • Suppressed a deprecation notice
  • Used rector to upgrade code

limenet avatar Jul 07 '23 07:07 limenet

@limenet I've alsi copied to a custom package for personal use, I've been using some of the functionality that the package offers. I've not had any problems so far.

Your readme looks amazing!

OzanKurt avatar Jul 07 '23 23:07 OzanKurt