rhdf5 icon indicating copy to clipboard operation
rhdf5 copied to clipboard

allow custom HDF5 data types in h5createDataset and h5writeDataset

Open ilia-kats opened this issue 2 years ago • 2 comments

This useful when one has a custom type, but still wants to use the default HDF5 spaces, DCPLs etc. that these functions provide. For example, when writing logical vectors that are compatible with Python's h5py, one needs to create a custom enum type with H5Tenum_create.

ilia-kats avatar Oct 12 '23 09:10 ilia-kats

AFAICT the CI is failing somewhere in the testthat package itself, not due to my changes.

ilia-kats avatar Oct 12 '23 10:10 ilia-kats

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e2e4ef7) 79.03% compared to head (f32940d) 78.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #130      +/-   ##
==========================================
- Coverage   79.03%   78.70%   -0.34%     
==========================================
  Files          36       36              
  Lines        1994     2005      +11     
==========================================
+ Hits         1576     1578       +2     
- Misses        418      427       +9     
Files Coverage Δ
R/h5create.R 83.14% <40.00%> (-1.34%) :arrow_down:
R/h5write.R 81.04% <57.14%> (-3.21%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 12 '23 10:10 codecov[bot]