sanctuary-zero
sanctuary-zero copied to clipboard
Commit for issue #12.
modified the notify_mesej function to have chatroom argument, that gives the information about user to a specific chatroom and reduces the network overload.
@adhyay2000 you are requested to allow some time to review your PR. Continually closing and opening of pull requests on your accord does not help the contributors and literally ends up wasting time which they spent on reviewing a PR which could not be merged as it was prematurely closed by the requester.
Thank you for understanding.
For your reference, @vinmay @shivangswain @VaibhavSaini19 @s-katte
Hi, I am sorry for closing the PR while it's still under review. After going through comments, I realized that server-side validation can only include server generating the chatroom name and client generating password themselves. However, this is now reduced to problem of not having same named chatroom, which is being addressed by @Vivek-blip ,i guess in issue #37 . So, I closed it to avoid anyone's wastage of time. This commit is basically undoes the work done for server-side validation and only contains work for reducing the network usage, while querying the available message