sanctuary-zero icon indicating copy to clipboard operation
sanctuary-zero copied to clipboard

Chatroom with the same name should be allowed to be created

Open gridhead opened this issue 3 years ago • 9 comments

Check with the server and disallow chatroom creation if a chatroom with the same name already exists.

gridhead avatar Oct 16 '20 03:10 gridhead

Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo?

vinmay avatar Oct 16 '20 04:10 vinmay

Can I work on this?

adhyay2000 avatar Oct 16 '20 05:10 adhyay2000

Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo?

Two chatrooms with the same name lose their uniqueness so if a chatroom with a name exists, another chatroom with the same name should not be allowed to be created. Do you want this issue to be assigned to you?

gridhead avatar Oct 16 '20 05:10 gridhead

You have been assigned 2 issues from this repository as of now @adhyay2000 and @vinmay has been assigned 1 issue. I would suggest completing them first before moving onto this one.

gridhead avatar Oct 16 '20 16:10 gridhead

Hii @t0xic0der please assign this issue to me. I am intersted in working this.

Luv8436 avatar Oct 17 '20 03:10 Luv8436

Cool. I am assigning this issue to you. @Luv8436

Feel free to leave a star at the repository if you find it useful.

gridhead avatar Oct 17 '20 05:10 gridhead

@Luv8436 did you make any progress on this?

Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @Vivek-blip

gridhead avatar Oct 18 '20 15:10 gridhead

@Luv8436 did you make any progress on this?

Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @Vivek-blip

Yes i'm interested in solving this issue

thevivekmnair avatar Oct 18 '20 16:10 thevivekmnair

Hi @Vivek-blip, you can see the PR opened by me. It already contains the code for generating the chatroom name at server side, you can maintain a set there to ensure just unique names are generated. It will solve the issue i guess. What do you say?

adhyay2000 avatar Oct 21 '20 02:10 adhyay2000