Akashdeep Dhar

Results 248 comments of Akashdeep Dhar

There would be some time before I can review this pull request @vinmay due to the fact that we are still waiting on the original assignee to turn up with...

> Sorry teachers dumped us with hw and I could not check GitHub, I closed my PR Umm. The PR is still open. You can renounce your assignment so that...

Sure thing. I am assigning this to you. Feel free to leave a star at the repository if you find it helpful.

There are certain flaws to this approach here. - Firstly, the list is to be maintained at the server end (namely `main.py`) so that the joining clients can convey their...

> Will this approach work? > Inside `/cnew.py` under the `producer_handler()` function, we need to handle for this `/list` case and send a websocket request(don't know whether this is valid...

@vinmay you are right. That needs to be maintained. What service are we opting for to implement this? Some alternatives I had in mind were CodeClimate, Travis CI and Circle...

@VaibhavSaini19 and @s-katte have exhaustive experience in this too. What do you folks think?

Yes @vinmay, a linter would be in order and that is what we'd be equipping for CI. For every push made to master or pull request created, the CI would...

> @t0xic0der This also makes me think, should the structure of the repo change as well? I mean have a client/sever is separate folders, add a setup.py file as well?...