Gridap.jl icon indicating copy to clipboard operation
Gridap.jl copied to clipboard

Added a test to RefinementRulesTests.jl that fails and should not

Open amartinhuertas opened this issue 1 year ago • 3 comments

Solves failing test https://github.com/gridap/Gridap.jl/blob/09b6e9b6fb8588d5087a87054f471ee14559ae3f/test/AdaptivityTests/RefinementRulesTests.jl#L26

amartinhuertas avatar Jul 18 '23 05:07 amartinhuertas

On a related note, which we do not have to solve in this PR ...

For mixed meshes, I think we are going to have a similar problem, as the polytope is a type parameter of RefinementRule.

amartinhuertas avatar Jul 18 '23 07:07 amartinhuertas

@amartinhuertas Yes, this is something I already encountered in the past. We discussed it, and we ended up agreeing that we will probably have to remove most template parameters from the RefinementRule structure in order to not have problems with mixed meshes... It's a shame, but it should not lead to performance issues since the number of different refinement rules should stay relatively small at all times.

JordiManyer avatar Jul 29 '23 00:07 JordiManyer

We discussed it, and we ended up agreeing that we will probably have to remove most template parameters from the RefinementRule structure in order to not have problems with mixed meshes...

Yes, we discussed it, and took some action, as far as I remember (namely, redefinition of type parameters for RefinementRule). These changes solved issues with TRIs but not with QUADs, even with no mixed meshes. In any case, as you say, with mixed meshes is going to be hard to bypass this problem if we stick to type paremeters in RefinementRule.

amartinhuertas avatar Jul 31 '23 02:07 amartinhuertas