Gridap.jl icon indicating copy to clipboard operation
Gridap.jl copied to clipboard

added get_cell_weights to DomainContributions.jl

Open hammy4815 opened this issue 1 year ago • 4 comments

See #907 .

This PR adds the get_cell_weights() methods required to access lower level access to quadrature points.

hammy4815 avatar Jun 16 '23 17:06 hammy4815

hi @hammy4815 ! Thanks for the PR. It turns out that the tests failed in Github actions. Can you please run Gridap tests locally and see if the problem reproduces in your local environment? If yes, can you please fix it and push? Thanks!

amartinhuertas avatar Jul 12 '23 22:07 amartinhuertas

hi @hammy4815 ! Thanks for the PR. It turns out that the tests failed in Github actions. Can you please run Gridap tests locally and see if the problem reproduces in your local environment? If yes, can you please fix it and push? Thanks!

I had accidentally kept internal calls to Gridap types and functions such as Gridap.CellData.CellQuadrature rather than just CellQuadrature and a few other examples. They should be removed now.

hammy4815 avatar Jul 15 '23 23:07 hammy4815

I had accidentally kept internal calls to Gridap types and functions such as Gridap.CellData.CellQuadrature rather than just CellQuadrature and a few other examples. They should be removed now.

No worries. Can you please add the corresponding entry in NEWS.md file? Thanks!

amartinhuertas avatar Jul 16 '23 07:07 amartinhuertas

Codecov Report

Merging #909 (e9303fc) into master (94419b8) will decrease coverage by 0.03%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   88.50%   88.47%   -0.03%     
==========================================
  Files         172      172              
  Lines       20121    20121              
==========================================
- Hits        17808    17802       -6     
- Misses       2313     2319       +6     
Impacted Files Coverage Δ
src/CellData/DomainContributions.jl 79.20% <0.00%> (-12.75%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 16 '23 08:07 codecov-commenter