Egret icon indicating copy to clipboard operation
Egret copied to clipboard

Degrees vs Radians inconsistency...

Open carldlaird opened this issue 3 years ago • 2 comments

It looks like we read in "degrees" for voltage angles from the matpower based input files. However, our Pyomo models are in radians. When they put the data back into the model data object (following a solve), it looks like they are not being converted back to degrees.

carldlaird avatar Mar 04 '21 20:03 carldlaird

My suggestion (putting it here for posterity) is to add this to (and perhaps refactor/move) the scale/unscale capability. It probably should be its own module, at minimum. https://github.com/grid-parity-exchange/Egret/blob/13d759a3a43be1522b8fb3c9c18035b1bf785efc/egret/model_library/transmission/tx_utils.py#L209-L482

bknueven avatar Mar 05 '21 22:03 bknueven

This is definitely a broad issue. For example, when we write incumbent-finders or fixing schemes that are problem-specific, e.g., for unit commitment, we're working typically working directly on Egret models. I'm with Ben in that the we need a general scale/unscale module, to include angles, the stuff Ben mentions above, and anything per-unit related.

jeanpaulwatson avatar Mar 07 '21 00:03 jeanpaulwatson