gridjs icon indicating copy to clipboard operation
gridjs copied to clipboard

Sorting with Undefined Values

Open ldrummond opened this issue 1 year ago • 2 comments

Column sorting doesn't work as expected when column contains undefined values.

To Reproduce Steps to reproduce the behavior:

  1. Create a table
  2. Add data as array of arrays, with sample values
[
 [undefined],
 [100],
 [300],
 [undefined],
 [50]
}
  1. Test sorting of column; sorting does not occur. No errors are thrown.

** Device

  • Chrome, Brave
  • NPM Version 6.1.1

Additional context May be able to fix by 1. Adding check for undefined in native sort function 2. Passing order (asc, desc) to comparator function for custom handling of undefined values. Unfortunately don't currently have time to check all possible causes and write PR, but may be able to in the next few weeks.

ldrummond avatar Feb 14 '24 22:02 ldrummond