rethinking-voxels icon indicating copy to clipboard operation
rethinking-voxels copied to clipboard

Published 20 hours ago • verified publisher icon gri573

Refactor IPBR to be a standalone toggle

Open dairymoose opened this issue 10 months ago • 1 comments

IPBR was mutually exclusive with LabPBR/SeusPBR. Now it can be toggled on or off at will

Note that if this is not in the spirit of this shader, feel free to decline this PR.

dairymoose avatar Apr 06 '24 04:04 dairymoose

Hello, thank you for the pull request! This is something that I would prefer not to do in rethinking voxels in order to minimise code divergence relative to complementary. However, I will tell emin (developer of complementary) to look at this, as they previously denied requests to toggle iPBR and resource pack based pbr separately with the argument that the code would become too spaghetti-like, which seems not too bad in your implementation.

gri573 avatar Apr 11 '24 06:04 gri573

Hey, I think I will decline this PR as Emin said they wouldn't add it to Complementary. Thank you anyway!

gri573 avatar Jun 11 '24 09:06 gri573