ProPresenter7-Proto icon indicating copy to clipboard operation
ProPresenter7-Proto copied to clipboard

fixes for Java specific items

Open darinpope opened this issue 1 year ago • 1 comments

when doing protoc for Java, these were a few items that needed to be cleaned up:

proCore.proto:6:1: warning: Import action.proto is unused.
[libprotobuf WARNING google/protobuf/compiler/java/file.cc:235] dmxProfiles.proto: The file's outer class name, "DmxProfiles", matches the name of one of the types declared inside it when case is ignored. This can cause compilation issues on Windows / MacOS. Please either rename the type or use the java_outer_classname option to specify a different outer class name for the .proto file to be safe.
[libprotobuf WARNING google/protobuf/compiler/java/file.cc:235] keymapping.proto: The file's outer class name, "Keymapping", matches the name of one of the types declared inside it when case is ignored. This can cause compilation issues on Windows / MacOS. Please either rename the type or use the java_outer_classname option to specify a different outer class name for the .proto file to be safe.

darinpope avatar Jul 21 '22 00:07 darinpope

Sorry I've missed this for so long... I'll need a bit of time to think how to best approach - as I have a bit of an automated process to generate the proto - and the next time I run it - it would loose your custom changes...

greyshirtguy avatar Sep 10 '22 03:09 greyshirtguy