i3status-rust icon indicating copy to clipboard operation
i3status-rust copied to clipboard

v0.30: battery block regression when device is missing (UPower)

Open ammgws opened this issue 3 years ago • 2 comments

When device is not available the block errors, but it should just be hidden since hide_missing = true:

image

[[block]]
block = "battery"
driver = "upower"
device = "battery_ps_controller_battery_d0obcoc1oe6o57o5c"
format = "PS5: $percentage|PS5: N/A"
full_format = "PS5: $percentage"
hide_missing = true
[block.theme_overrides]
alternating_tint_bg = "#FFFFFFFF"
alternating_tint_fg = "#FFFFFFFF"
# TODO: change to confirm menu
[[block.click]]
button = "left"
cmd = "allow_only_one_instance sway_setup_tv_gaming"

ammgws avatar Jun 19 '22 16:06 ammgws

Yes, missing battery detection is not implemented for driver = "upower".

MaxVerevkin avatar Jun 19 '22 16:06 MaxVerevkin

Ah yes, one of the remaining features not yet implemented: https://github.com/greshake/i3status-rust/pull/1383 https://github.com/greshake/i3status-rust/pull/1378

ammgws avatar Jun 19 '22 16:06 ammgws

@bim9262 Since you seem to be on v0.30 now, have you been hit by this again?

ammgws avatar Feb 02 '23 04:02 ammgws

I don't use upower on a machine with removable battery so I haven't noticed.

bim9262 avatar Feb 02 '23 04:02 bim9262

Ah OK, I thought that you did since you were the one who implemented https://github.com/greshake/i3status-rust/pull/1378

ammgws avatar Feb 02 '23 10:02 ammgws