nest-winston icon indicating copy to clipboard operation
nest-winston copied to clipboard

Allow for `WinstonLogger` to be extensible

Open hjpotter92 opened this issue 2 years ago • 1 comments

Currently, the constructor defines a private readonly logger property, making its child class declaration nearly impossible. (https://github.com/gremo/nest-winston/blob/master/src/winston.classes.ts#L8).

Perhaps, having the logger property as protected would allow others to maybe able to expand the base class?

I am not sure if this is already possible, but I could not find anything relevant in the docs, hence the issue/thread.

hjpotter92 avatar Dec 01 '21 18:12 hjpotter92

I'm sorry for the very late response, I'm quite busy recently with my personal and working life. I'll try to follow more this library that, honestly, went so far and has been used by many. Didn't expected that 😄

Anyways, should we do this? What about BC? I don't know but making that field protected seems wrong to me. Can you provide an example of a custom implementation and advances?

gremo avatar May 12 '22 10:05 gremo

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 07 '23 01:07 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Jul 14 '23 01:07 github-actions[bot]