SdFat-Particle icon indicating copy to clipboard operation
SdFat-Particle copied to clipboard

MIT license for Particle version as well?

Open hydrojumbo opened this issue 8 years ago • 5 comments

Hello,

I noticed you recently changed the license terms for the SdFat library from GPL to MIT (issue, change). Is this something you would consider doing for the Particle adaptation of this library as well?

hydrojumbo avatar Oct 23 '17 19:10 hydrojumbo

I'd love to see this updated as well!

rbenji23 avatar Oct 03 '18 18:10 rbenji23

I second that as well as updating it to work with the new Particle mesh devices. Thanks for a great library!

mawrob avatar Jan 10 '19 23:01 mawrob

I am working on the update. See this.

greiman avatar Jan 11 '19 14:01 greiman

Thank you! I tried it and it compiled. I'm using it for another library by Rikkas7 and am now trying to work though why his no longer works with your new version: https://github.com/rickkas7/SdCardLogHandlerRK/issues/2

mawrob avatar Jan 11 '19 19:01 mawrob

There are still problems on gen3 boards with SdFat. See this.

At least one problem with the SdCardLogHandlerRK library is that this call no longer takes a divisor.

sd.begin(csPin, divisor);

It takes an SPISettings object like this:

sd.begin(csPin, SD_SCK_MHZ(50)

This will select the highest SPI speed supported by the board that is <= 50 MHz.

greiman avatar Jan 11 '19 20:01 greiman