SSD1306Ascii icon indicating copy to clipboard operation
SSD1306Ascii copied to clipboard

Add support for the vertically orientated SH1107

Open jonathanmlang opened this issue 1 year ago • 4 comments

Requires the fix in issue #104 to be applied.

jonathanmlang avatar Mar 01 '23 18:03 jonathanmlang

None of your pull requests will be applied since I have a private beta. It may be a few months until I post mods I have made to the beta.

I have about a dozen displays and test all before new versions.

greiman avatar Mar 01 '23 18:03 greiman

Thats fine, Just wanted to put it out there for you to decide what you wanted to do. Just thought this was the best way of suggesting these things. For now I wont be contributing any more to this library other than bug reports.

jonathanmlang avatar Mar 01 '23 18:03 jonathanmlang

I probably should have a beta version of this library. It is amazing how often simple mods break apps for users.

Today I found that this fails on many "Arduino compatible board packages".

Serial.write("abcdefghijk", 5);

Arduino has this in Print.h:

    virtual size_t write(const uint8_t *buffer, size_t size);
    size_t write(const char *buffer, size_t size) {
      return write((const uint8_t *)buffer, size);
    }

Many board packages don't have the support for const char* so my entire SdFat library won't compile on these boards.

That's why I stopped applying what looks like simple mods.

It means a huge amount of testing for each release. I need to run many examples on many boards and displays.

greiman avatar Mar 01 '23 18:03 greiman

Thats fair enough, ive been on the recieving end of that on many occasions when I download the latest version of other peoples libraries and find something really basic is broken due to a new feature rendering it useless. marlin firmware being one of the worst ive experienced off the top of my head.

jonathanmlang avatar Mar 01 '23 19:03 jonathanmlang