Greg Reimer
Greg Reimer
I'd accept a PR for this. Relevant API: https://nodejs.org/api/http.html#http_message_statusmessage
Note: I'm working toward a 1.0 version, but there's a v0.x maintenance branch to support the previous version.
Definitely seems nice to have. Can someone point to a gist or code sample of this being implemented in node? I may chase it down myself eventually, but a lot...
What sort of problems? I don't think it should URL-encode the value since it would cause already-encoded values to get double-encoded. A routine to encode just invalid characters might work,...
Ah okay. So yeah it isn't the browser generating the URL in this case. Re-reading that code, I'm remembering now issues surrounding path differences on Windows versus other platforms. Presumably...
`req.url` is root-relative because that's how node http servers (and express) do it. At least that was my thinking at the time :) Maybe when the next major version comes...
Short of breaking changes, we could alias `url` => `path` and refer to that instead in the docs if you think that would help. I'd accept a PR for that.
Thanks for taking the time to do a PR. I'm concerned since these changes would force the same configuration on every running instance of a proxy, it could create bugs...
~~Also, regarding tests, I haven't run them on more recent versions of Node. Have you verified the test failures are happening against only your branch, or against master also?~~ Never...
Just pushed an update that fixed the test failures on my end. Let me know if you still run into issues.