Greg Wilkins

Results 470 comments of Greg Wilkins

@ludoch note that I could fairly easily make a lot of the optimizations from this branch in the main branch as well. There is actually no need to use Servlets...

See #241 that removes Servlets from the current jetty-9 usage, which should give reasonable savings in memory and CPU. See #244 That upgrades to Jetty-10 for a more modern/efficient HTTP...

Hmmm is removing deprecated methods "incompatible"? Ideally we could do that in 5.0, but if not then in a 5.1. If we can't do that during a name change then...

I still like `Documentation` as there are many issues that are not about changing behaviour, rather just improving the description of it. Also as we no longer have a spec...

I'd be very cautious about such a change. Often beans are used in configuration, which is done before a doStart call.

The object passed to `addBean` should be fully constructed, so that should not be an issue. References to `this` by AbstractContainer are a bit more problematic, but they at least...

I understand the issue. But the proposed cure is worse than the disease. Potentially we should deprecate the newly added convenience constructor that passes in a `Handler` and make an...

If we had an `protected void addBeanFromConstructor(Object)` in `ContainerLifeCycle`, then it could avoid calling any listeners, because there should be none registered yet.... unless an object passed to `addBeanFromConstructor` was...

@joakime @sbordet see #11319 for a speculative fix for this issue.

@sbordet during construction, there should be no listeners that installBean needs to call. I've only found one case where an installed bean was itself a listener and it was an...