Greg Wilkins
Greg Wilkins
@sbordet sorry I missed a few comments. I'm having troubling making the new intellij review mode update always. I think I have got them all now.
@sbordet please don't review saying "this method is not used". Just imagine that it is used and review on the basis of asking is it the right API in the...
See #11599 for the Mutable API
@lorban thanks for the review. I've fixed most, but will ponder some for a while....
> Just use getBB() and then the `ByteBuffer` APIs. @sbordet by saying this you indicate that you still do not understand the intent of this PR. Yes I know there...
> @gregw I had a look with @lorban and below my thoughts. @sbordet Thanks for the long detailed analysis, but I think I see a few things that you've got...
I'm just going to summarize the objectives of this crusade! + Homogenize the APIs used for buffer manipulation in utils, aggregators, accumulators and buffers. Currently we have several different naming...
@lorban I've done a bit more work on this. Have a look the new implementations: `RBB.FixedCapacity` and `RBB.DynamicCapacity`. The latter is the replacement for both accumulators and aggregators. Rather than...
@lorban I'm interested in your thoughts about the latest version of this PR. Specifically the RBB.FixedCapacity vs RBB.DynamicCapacity classes. The intent of the DynamicCapacity class is to replace both aggregators...
Closing in favour of a new PR with less history....