Results 119 comments of Greg Sheremeta

I've extracted the PipelineConfig addition to its own PR, #11112. Regarding the TTL portion of this PR, I don't see anything in Argo Workflows or kubernetes to allow setting TTLs...

> Maybe we can disambiguate between etcd TTL (for runs) and KFP database TTL (for runs). I think it's important to be able to configure both separately. This was in...

Design Doc: Kubeflow Pipelines - Design - Implement TTL for pipeline runs - Google Docs https://docs.google.com/document/d/1Aakg7udmM_YLEU7gqGi9PbowTZDscy_zzVRx0CcAXeQ/edit

@chensun do you know whom I can nag about reviewing kfp-kubernetes PRs? I ask because it seems like Connor left the project.

s/WIP// I think it's good for final review

@chensun can you re-lgtm this? I made the empty_dir_mount -> empty_dir_mounts change you asked for, and the lgtm was removed

To @diegolovison 's point, I also noticed this in the compiler today. There's a strong argument to be made for keeping the user interface consistent. https://github.com/kubeflow/pipelines/blob/1c7954de261b22fa93905cf11b6b280fdf19c320/sdk/python/kfp/cli/compile_.py#L131-L135 @DharmitD , how difficult...

[Link to KFP community meeting](https://drive.google.com/file/d/1LmpNI6sJAcFZEj1-F2kl_s3BlkiP1v_i/view?usp=sharing&resourcekey=0-wxEZBbugQhoDerN0eXuWiw) where this issue was discussed

> tldr: we should try to use [Argo Lifecycle Hooks](https://argo-workflows.readthedocs.io/en/latest/lifecyclehook/) here instead of having the exit_task be another sibling task to the ExitHandler. Thanks for the great writeup above. This...

@zazulam your team has implemented a DSL on top of a DSL :expressionless: :exploding_head: because here we have a yaml abstraction on top of python so we can write pipelines...