recurring_select icon indicating copy to clipboard operation
recurring_select copied to clipboard

CSS breaks when used with Foundation

Open ndbroadbent opened this issue 10 years ago • 6 comments

screen shot 2014-05-06 at 2 07 17 pm

Nothing too terrible

ndbroadbent avatar May 06 '14 21:05 ndbroadbent

Here's the CSS I used to fix the issue:

.rs_dialog_content .freq_option_section .rs_interval {
  display: inline-block;
}

.rs_dialog_holder {
  font-family: inherit;
}

.rs_dialog_content  a {
  -moz-box-sizing: content-box;
  -webkit-box-sizing: content-box;
  box-sizing: content-box;
}

.rs_dialog_content p {
  line-height: 14px;
}

Result:

screen shot 2014-05-06 at 2 20 54 pm

ndbroadbent avatar May 06 '14 21:05 ndbroadbent

Hey @ndbroadbent, if you send this as a PR, and I'll test it and make sure it doesn't break without foundation. If everything is good, we should be able to hit merge pretty quickly.

forrest avatar May 06 '14 21:05 forrest

Will do! P.S. What's up with the terrible formatting in the CSS? All the rules are on one line, separated by semicolons..

ndbroadbent avatar May 06 '14 21:05 ndbroadbent

It's how I used to write CSS when I was a sole developer. Never bothered upgrading it. If you clean it up and send a PR, I'll merge that too ;-)

forrest avatar May 06 '14 21:05 forrest

Alright, might do that too :) Thanks for the awesome library!

On Tue, May 6, 2014 at 2:34 PM, Forrest Zeisler [email protected]:

It's how I used to write CSS when I was a sole developer. Never bothered upgrading it. If you clean it up and send a PR, I'll merge that too ;-)

— Reply to this email directly or view it on GitHubhttps://github.com/GetJobber/recurring_select/issues/49#issuecomment-42362344 .

ndbroadbent avatar May 06 '14 21:05 ndbroadbent

This might be helpful to others. I took the liberty of fluffing up the layout a bit.

.rs_dialog_content .freq_option_section .rs_interval {
  display: inline-block;
}

.rs_dialog_holder .rs_dialog .rs_dialog_content .freq_option_section {

  .rs_calendar_week {
    width: 260px;

    a {
      width: 25px;
      line-height: 18px;
    }
  }

  .rs_interval {
    width: 60px;
  }

  .day_holder {
    height: 30px;
    a {
      text-align: center;
      width: 30px;
      line-height: 20px;
      padding: 5px 3px;
    }
  }

  .rs_calendar_day {
    width: 260px;

    a {
      width: 30px;
      line-height: 20px;
    }

    a.end_of_month {
      width: 141px;
    }
  }
}

.rs_dialog_holder {
  font-family: inherit;
}

.rs_dialog_content  a {
  -moz-box-sizing: content-box;
  -webkit-box-sizing: content-box;
  box-sizing: content-box;
}

.rs_dialog_content p {
  line-height: 14px;
}

Result

recurrence 1 recurrence 2

voltechs avatar Feb 14 '15 09:02 voltechs