gregorio icon indicating copy to clipboard operation
gregorio copied to clipboard

Commentary text overlapping with text above

Open Nokel81 opened this issue 4 years ago • 6 comments

Given the following latex:

\scriptsize
The mouth of the just man tells of wisdom and his tongue utters what is right. The law of his God is in his heart. Ps. Be not vexed over evildoers, nor jealous of those who do wrong.
\normalsize
\grecommentary{\linespread{1.15}Ps. 91, 13, 14; Ps. 91, 3}
\gregorioscore{Confessor/Mass1/Graduale}

It produces the following when compiled with LuaLaTex+se (following the set up on the website).

image

Nokel81 avatar Aug 17 '19 14:08 Nokel81

I usually just add some \vspace .

fiat96 avatar Mar 13 '20 15:03 fiat96

That is a potential fix in the interum, but the boundaries of a score should not be less than where items are drawn

Nokel81 avatar Mar 13 '20 16:03 Nokel81

Another problem, which I think is probably worse. I that grecommentary sometimes overlaps with notes:

image

Nokel81 avatar Jan 31 '21 20:01 Nokel81

The first problem (commentary overlapping with text above) is because the commentary box contents are not taken into account when computing the line height for the first line. I'm not immediately sure why, but I'll look into this.

The second problem (commentary overlapping with high notes) is because the commentary box position does not look at what the highest note on the line is. This information is not available from the current run because the commentary box is printed before any of the notes, and thus must be retrieved from a previous run.

Fixing the second definitely involves messing around with the lua code that stores and retrieves line height information between passes, but I'm not familiar enough with that to say how at this point. @henryso can you provide some insight here?

rpspringuel avatar Feb 06 '21 21:02 rpspringuel

Thanks for the response. For the time being I added 4mm of height to the \grecommentary invocation. I'll open a PR for the website to add information that \grecommentary has an optional argument for additional height (since I found that out by reading the release notes).

Nokel81 avatar Feb 07 '21 17:02 Nokel81

I've just put together that PR: gregorio-project/gregorio-project.github.io#102. @Nokel81 please look it over.

rpspringuel avatar Feb 07 '21 19:02 rpspringuel