Greg Marr

Results 221 comments of Greg Marr

`string_view` support already exists through this function: ``` /// @brief access specified object element /// @sa https://json.nlohmann.me/api/basic_json/operator%5B%5D/ template = 0 > reference operator[](KeyType && key) ``` https://github.com/nlohmann/json/pull/3423 As you can...

>My idea is to add specific string_view overloads for operator[] to guide the compiler in choosing the correct one, resolving the ambiguity. Okay, that's not what your PR description says,...

I was hoping for something that didn't have to name `string_view` directly, but I'm not sure that's possible. Another possibility that seems to work and doesn't require any changes to...

@nlohmann will have to help you with the checks. > I also agree that in the future, we should aim to support full std::string_view handling as a proper feature of...

I don't understand what's happening with this PR. It is not showing the change in the original file, but it is showing it in the amalgamated file, and there's no...

There are whitespace changes in the amalgamated header, but no changes in any of the other headers, so the base commit was not properly amalgamated (unlikely) or there's a problem...

I think you might need to start over with a single fresh commit that just fixes the test, due to the DCO checks, and the older commits that aren't signed...

Are you using `JSON_USE_IMPLICIT_CONVERSIONS` set as `false`? If so, you can't use 3.12.0, you need to use the latest `develop` branch until a new release is made. >By skimming over...

It works in general: https://www.godbolt.org/z/1qhe8PY55 Can you try to compile that simple file in your environment and share the full error? There may be clues in that output.

First, if possible, you should set this before including the header to disable the implicit conversions: ``` #define JSON_USE_IMPLICIT_CONVERSIONS 0 ``` Then get the data from the json object like...