first_nes icon indicating copy to clipboard operation
first_nes copied to clipboard

missing code for background data

Open ghost opened this issue 4 years ago • 4 comments

Looking through tutorial here i notice that the first_nes codebase seems to lack code to copy the nametable etc to memory.

unless im mistaken?

link 1 https://taywee.github.io/NerdyNights/nerdynights/backgrounds.html

ghost avatar Oct 06 '19 01:10 ghost

You're correct-- I intentionally omitted it for the time being.

However, that's a good idea to include it. I don't have time to do it right now, but if you want to fork the repo and submit a really clean pull request for it, I'd be happy to add you as a co-author.

gregkrsak avatar Oct 06 '19 01:10 gregkrsak

that's cool and understandable, i will try to provide a pr soon. thanks for quick response

ghost avatar Oct 06 '19 01:10 ghost

pr sent. hopefully i have presented it in a way that fits your style.

ghost avatar Oct 18 '19 09:10 ghost

This code is now in branch patch_01 for further development.

I had initially merged the pull request into staging, but felt it wasn't complete enough. I'm excited to work on this more (or have you work on it), but it needs a little cleaning up before hitting staging or master.

gregkrsak avatar Jan 15 '20 07:01 gregkrsak