Greg Hill

Results 60 comments of Greg Hill

Also agree with the proposed solution (option 3), this should allow us to revise the staking architecture (i.e. remove `slashTally`, `slashPerToken`, etc.) since the nominator's collateral can be calculated as...

> We can't supply a btc address as argument Why not? Do you mean from a UX perspective? In that case we can just use the master key which is...

Had a discussion with @sander2, we believe the best way forward is to re-use the issue and redeem logic. @nakul1010 hold-off on the implementation for now until we've had a...

We will refactor the `replace` pallet to reuse `issue` and `redeem` events / structs. Let's assume Vault A (`old_vault`) now wants to move their BTC to Vault B (`new_vault`) we...

We had a call to discuss the approach and I think we are in agreement. Let's still remove the `replace` pallet (and `Vault` struct fields) but modify the following structs:...

Linking https://github.com/interlay/interbtc/pull/932, see @sander2's open comment.

Related: https://github.com/interlay/interbtc/issues/724 https://github.com/interlay/interbtc/issues/1110

This comes from the Substrate build script [here](https://github.com/paritytech/substrate/blob/ff24c60ac7d9f87727ecdd0ded9a80c56e4f4b65/utils/build-script-utils/src/version.rs#L44) which uses `CARGO_PKG_VERSION` - read from the package `Cargo.toml` file. We tend not to update this manually since we don't publish the...

- **Problem 1**: You can iterate over the previous forks, electrum does that [here](https://github.com/spesmilo/electrum/blob/cee22abcb5544c5a6fa7f8a8108ccda9c32c2e29/electrum/blockchain.py#L464-L465) - **Problem 2**: You'll have to figure out a good way to test this :) maybe...

Since we forked the Zenlink code it may be possible to use a `PoolId` to identify LP tokens in `dex-general`. This would negate the need to duplicate fields in the...