pushover icon indicating copy to clipboard operation
pushover copied to clipboard

Published 20 hours ago • verified publisher icon gregdel

check for error in message.AddAttachment

Open antcs opened this issue 4 years ago • 6 comments

antcs avatar Aug 17 '20 15:08 antcs

Coverage Status

Coverage remained the same at 80.217% when pulling c73cf4e9682a8a50d52c9101e2669f15a21474ce on antcs:check-error into 505cfd60a3406752dc18beca43566c30938d7cdc on gregdel:master.

coveralls avatar Aug 17 '20 15:08 coveralls

Hello, thanks for your contribution !

I think the commit message should updated:

  • it should start with an uppercase letter
  • it could be more clear to specify that you're updating the tests and not the library itself

gregdel avatar Aug 18 '20 08:08 gregdel

@gregdel Can you have a second look?

antcs avatar Aug 20 '20 12:08 antcs

Hello, I just merged you other PR, this one is now in conflict. Could you rebase this PR ?

gregdel avatar Aug 20 '20 12:08 gregdel

@gregdel merge conflict resolved

antcs avatar Aug 20 '20 15:08 antcs

Could you rebase instead of merging, it would be better to have only one commit for this PR. There's multiple ways to to this but a simple way would be:

  • Go to your master branch and pull the latest changed
  • Go back to the branch containing the code for this PR and remove the commit we don't need (git reset --hard for exemple)
  • Use git rebase from master

You should end up with only one commit :)

gregdel avatar Aug 20 '20 15:08 gregdel