Gergő Nagy

Results 71 comments of Gergő Nagy

important dapps on mainnet that are not yet in the list (haven't verified which one of these support polygon yet) 1inch Maker Olympus Liquity Alchemix Fei Convex Compound Gnosis Synthetix...

@0xDaedalus is this good to be closed?

~~I think we have started using custom assets for assets with 0 balance at some point.~~ Don't comment based on vague memories and from mobile :) we use custom assets...

Yes, I think this is the way. Nit: I wouldn't revert that change but reintroduce a modified version [according to this comment](https://github.com/tallycash/extension/blob/main/background/services/indexing/index.ts#L294-L299) Nit2: The definition of [`baselineTrustedAsset`](https://github.com/tallycash/extension/blob/main/background/services/indexing/index.ts#L279) will also need...

> With this implementation, it's possible that the listener is called after unsubscribe. Probably not an issue with webext-redux, but in principle this could lead to inconsistencies. This is a...

@Shadowfiend, I will finish this as soon as nothing more urgent comes up. :( I would love to reach to a point where we don't need this FWIW, but I...

This pr has been on halt long enough to close it and return to it when we have the issue again. Hopefully we have mitigated the issues and we won't...

These ideas turned out not to be useful https://github.com/tallycash/extension/pull/1672#issuecomment-1169061170 - ~~[ ] Optimize main startup time~~ - ~~move store initialization into the `create()` function https://github.com/tallycash/extension/pull/1672#issuecomment-1167641973~~ - ~~move all redux stuff...

https://github.com/tallycash/extension/issues/1564#issuecomment-1183573986 There's a performance issue is mentioned here: https://github.com/tallycash/extension/issues/1742#issuecomment-1176375994 And discussion in [flowdock](https://www.flowdock.com/app/cardforcoin/tech/threads/tZtrk7Ye89GhvY51NDoXJfpMBUo) From a cursory look, `getCachedAssets` is merging assets I think twice per call. And `getCachedAssets` is running...