Greg Szabo
Greg Szabo
I've created a diagram from all the public structs in tendermint-rs that are serializable: https://imgur.com/a/YhWa7Hb # Current state We have three different types of serialization implemented for our structs. ##...
I'm going to add here Romain's example of hiding fields and validating them: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=389500b442c9ee697dc8c2511b8a14bb Might not be the solution we're looking for but it's an interesting concept. One note to...
All right, so if I understand correctly, you're advocating for getting rid of tendermint::Time in lieu of tendermint_proto::Timestamp since there's no real added value. So far, looking at the code...
Just confirmed, tendermint::Time is falling back to tendermint_proto::Timestamp for serialization. No issues there.
tendermint::Time has a lot of little convenience functions, like `now()`, `duration_since()`, `Display, String` traits, etc. These are used in all kinds of tests and also possibly in downstream projects. All...
Huh, ok, that's interesting. If you want to use it directly, there's no way to add additional functionality to it, like convenient protobuf-encoding/decoding or JSON serialization/deserialization. As Tony mentioned in...
I talked to Henry, and he considers the ed25519-consensus library done. All he could promise me is that he'll take a look at a PR if someone implements the feature....
Thanks for the ideas, Tony! I have implemented one version to discuss with Henry in [ed25519-consensus (PR 12)](https://github.com/penumbra-zone/ed25519-consensus/pull/12). It's incomplete; serialization can be cumbersome in a no_std world. Depending on...
The commit is part of the 0.35 branch. I wonder if they thought that the 0.35 implementation was different enough that the documentation was outdated.
Thanks, I can find different versions of the files, some in the spec repo, some in tendermint. The problem I'm tackling is how and why they disappeared. The commit mentioned...