Greg Anderson

Results 388 comments of Greg Anderson

I think that would have been the right solution.

Looks like you are installing Drush 8 as a site-local install in your Drupal site. What version of consolidatin/annotated-command are you using? This looks like something that was fixed a...

Does `vendor/bin/drush` exist in sites that are exhibiting the symptom?

We probably need some form of notification, even if it's only a debug log message, so that commands do not silently disappear when underlying things change in such a way...

Yes, I agree. The `--filter` option is not a direct feature of output-formatters, but is instead provided by [filter-via-dot-access-data](https://github.com/consolidation/filter-via-dot-access-data). Drush is [already configured to use this project](https://github.com/drush-ops/drush/blob/1f9e78ad1aace1efa26bbaaa2e30c628ff8f5bf6/src/Runtime/ServiceManager.php#L105). To add filters...

This will make it much harder for folks to diagnose misplaced `exit` calls, e.g. redirect logic in settings.php not guarded from cli use, etc.; however, I understand. I wonder if...

Current behavior, without this PR, after adding `exit(0)` to settings.php, to simulate bad redirect logic: ``` $ drush status [warning] Drush command terminated abnormally. $ echo $? 1 ``` With...

> I added a header() call to settings.php and it was did nothing in my test. I believe the pattern a lot of folks use involves calling `exit(0)` immediately after...

> We would have to keep too much of our shutdown api. Its not just setCompleted(). I am suggesting keeping the setCompleted function implementation itself, and the three calls that...

I prefer putting this in a Drush 13 branch, because otherwise it would be hard to know whether to add an auxiliary shutdown handler or not.