SatisfactoryTools icon indicating copy to clipboard operation
SatisfactoryTools copied to clipboard

feat: add "done" state to visualization

Open martingregoire opened this issue 1 year ago • 5 comments

Description

Allows to mark nodes in the visualization as "done" by double-clicking on them. A "done" node will be shown with a green background.

Double-clicking on a "done" node will reset them to their initial state.

Note: this "done" state is not persisted in LocalStorage, it is only saved in the visualization state. This means that if you e.g. reload the page, all nodes will loose their "done" state.

Demo

This is how it looks like:

sft-done-state.webm

martingregoire avatar Oct 03 '24 09:10 martingregoire

Hi @greeny, thanks a lot for your awesome Satisfactory Tools! :heart: I've been using them all the time to plan my factories.

One thing that I'm missing is the possibility to mark parts of a factory as "done" while building it. A different tool allows this by clicking a node, so I tried to implement something similar here.

Would be nice if you could have a look and leave some feedback. :slightly_smiling_face:

martingregoire avatar Oct 03 '24 09:10 martingregoire

The problem with this is that tabbing to another production line resets the "done" state (and refreshing does as well).

Refreshing would need saving the state, which is too much work, but it would be nice for the done state to persist between switching tabs at least.

Also, I'd prefer the nodes to not change color, but rather go to some "less opaque state" and keep their original color (that's how it worked before anyway).

greeny avatar Oct 03 '24 09:10 greeny

Yes I see your point, I'll try to move the "done" state further up, so it will be kept when switching production lines. :+1:

martingregoire avatar Oct 03 '24 10:10 martingregoire

Updated the PR (and demo video) - please check again @greeny. :slightly_smiling_face:

The "done" state is now in the GraphNode, so it is persisted when switching between production lines.

Also the node boxes will now change their opacity when "done" (to a value of 0.2 that I found somewhere in the code), instead of changing their background color.

WDYT?

martingregoire avatar Oct 03 '24 12:10 martingregoire

Came here to add the same feature but saw there was already a branch and pr made :) Please review if you have the time @greeny Also, thanks for all the work on SFT!

laurensvc avatar Oct 29 '24 14:10 laurensvc